adereth / dactyl-keyboard

Parameterized ergonomic keyboard
GNU Affero General Public License v3.0
2.92k stars 843 forks source link

More easily manipulable code #70

Open levihilton opened 5 years ago

levihilton commented 5 years ago

Hi, I was wondering if anyone has come across or has made code mimicking the existing clj code that would have set parameters for number of rows and number of columns one can have.

Basically I want to be able to have 5 rows and 8 columns in the main hand part of the keyboard. I've come across the issue where I am basically guessing which values I should change to be able to make these changes. I love this project, but it takes about 1 min 30 sec to re-render each time I make a guess, so progress is painfully slow.

Thanks in advance!

levihilton commented 5 years ago

To further clarify, I guess it would just be helpful to have the code a bit better commented with exactly which lines create which parts of the keyboard.

jaredjennings commented 5 years ago

The last commit to this repo was more than two years ago. There are more than 80 forks. adereth seems done with this project, and the most common current use of this Github repo is as a discussion forum for its user community. I will note that the last commit was a merging of a pull request; if I were adereth, I would rather accept your pull request that adds comments, than make my own change which you may not even find helpful. But don't hold your breath. Just maintain your own fork instead.

Of the existing forks: The Dactyl Marshmallow is mine. I had some three goals: make it better understandable, make it printable in pieces, and make it look cool (in my own personal estimation). Making something printable in pieces is easy; making sure the pieces will join exactly right is not. So it is not done. The Dactyl Manuform is particularly focused on easy support for different sizes, and many people have customized and built one. I just did. You have to slice it with Cura not Slic3r, and it is harder to sand than anything.

Now, the time to iterate was a big problem for me too. You can reduce wall-sphere-n to speed rendering, but the real win is if you just comment out new-case in the definition of dactyl-top-right, near the bottom of the file. You could even temporarily comment out connectors, till you start working on them.