search

adesigns / calendar-bundle

This bundle allows you to integrate the jQuery FullCalendar plugin into your Symfony2 application.
MIT License
97 stars 60 forks source link

Use component-installer for installing js dependencies #10

Closed arendjantetteroo closed 5 years ago

arendjantetteroo commented 10 years ago

With component-installer you can add the javascript dependencies you need in your project just in your composer.json and don't need to include the dependencies directly in your project. This allows easier updating them or allowing developers using other versions.

See also https://github.com/adesigns/calendar-bundle/issues/3

mikeyudin commented 10 years ago

Thanks, will test and merge as time allows over the next few days. This will probably be included in a separate version (1.2 most likely).

arendjantetteroo commented 10 years ago

Cool, let me know if you need help or details on how it works?

mikeyudin commented 10 years ago

Will do. I've played with the component installer a bit while using symfony2admingenerator, so I'm somewhat familiar. My concern is about causing a BC break if I merge into master.

mikeyudin commented 10 years ago

Although this might not be the best approach, I am wondering if for the time being, we should not remove the fullcalendar & jquery files, to maintain backwards compatibility in the master branch, while allowing users to begin using the component-installer? Perhaps in the next major release (2.0?) we remove these dependencies?

Thoughts?

arendjantetteroo commented 10 years ago

That's fine with me, I'm ok with some old files in the bundle, as long as the new files are installed with component installer and I can easily use those. A note about this in the Readme would suffice I think.

Regarding the BC break: the location of the files changed, what you could do is change the location where the files are copied by the component installer, but I am not sure this is worth the effort. And this might break other component installer items used by the user.