fullcalendar source is obsolete

[garak]

Current available version is 1.6.1, see http://arshaw.com/fullcalendar/download/ Maybe it would be a good idea to strip any Javascript/CSS source from bundle, while adding instructions on how to retrieve it from original websites

[mikeyudin]

I will look into upgrading the JS/CSS source. Stripping all of the JS/CSS from the bundle would defeat the purpose of it. The goal is to get the calendar up and running for users with minimal configuration. Users are free to implement their own JS/CSS solution as they see fit.

Additionally, fullcalendar does not appear to be available via composer, so this gives users easy access to it. Hopefully as this bundle gains more traction, users can help keep the source up-to-date.

Thoughts?

[garak]

I disagree: putting an external library in your bundle is a bad practice, since you're forced to update your code every time external library is updated. Best thing you could do is using a CDN for javascript and css. Unfortunately, full calendar seems not be available ad CDN resource (maybe you can open an issue with its author, or provide a CDN yourself). But please, at least strip out jQuery. And, as I already mentioned, just add a small doc to let users of your bundle be able to retrieve js/css libraries.

[nurikabe]

Add the following to your composer.json to grab fullcalendar:

"repositories": [
        {
            "type": "package",
            "package": {
                "name": "arshaw/fullcalendar",
                "version": "1.6.1",
                "dist": {
                    "type": "zip",
                    "url": "http://arshaw.com/fullcalendar/downloads/fullcalendar-1.6.1.zip"
                }
            }
        },
        ...
"require": {
        ...
        "arshaw/fullcalendar": "1.6.1",

[garak]

http://symfony.com/doc/master/cookbook/bundles/best_practices.html#vendors "A bundle should not embed third-party libraries written in JavaScript, CSS, or any other language."