Newly introduced e-mail address

adessoSE / budgeteer

Simple Project Budget Monitoring via Web Browser

MIT License

31 stars 19 forks source link

Newly introduced e-mail address #322

Open tinne opened 6 years ago

tinne commented 6 years ago

In preparation for a proper admin interface, Budgeteer has introduced an e-mail address for users and warns me that I ought to enter one. Good migration policy!

However, in the “Edit User” dialogue that follows, I am forced to change my password (ok, i could enter the old one three times...) in order to add an e-mail address. This should not happen:

People should be able to change their e-mail address without changing their password. Forcing “current password” to be given is ok.
It is ok that if new password is given, both retype new password must be given (and identical) and the e-mail address should be given and well-formed.

maximAtanasov commented 6 years ago

The user is not forced to type in a new password. You can change only the username or the email and leave all three password fields empty and the form will be submitted successfuly. Perhaps we did not make that clear. The only issue I found was that when changing the username, the user has to log out and then back in. That should be an easy fix.

As for changing the password. Would something like the checkbox in the second option in the following mockup be more clear?

(Change password in our case, not username)

tinne commented 5 years ago

Perhaps we did not make that clear.

No, it was how form validation worked. As the stars on the left hand side suggest, new password and repeat password were just mandatory fields, error message “The new password may not be empty!”

Regarding the change of the user's name, of the given two I'm more in favor of option N2, but let me suggest separating these two items even further, see my [Budgeteer UI Suggestions.pdf].(https://github.com/adessoAG/budgeteer/files/2610275/Budgeteer.UI.Suggestions.pdf)

maximAtanasov commented 5 years ago

Hmm, that's strange, it seems to work for me, maybe it's because you are always entering the old password? But anyway, the form will be remade as you suggested. Thank you very much for the mockups, they look very nice and I we will implement them. :)

tinne commented 5 years ago

You are of course right about me always entering the old password, as many tools today enforce a password to change sensitive profile information.

The mock-ups were made using Balsamiq Mockups 3. If you are interested in the source file kindly send a PN.

KilianKrause commented 5 years ago

This has been implemented in PR #333