Closed adeutscher closed 10 years ago
Revamped getProperties
.
Forgot to document one other detail in ticket: I also corrected an error that I had made with getProperties()
' use of PropertyNotFoundException
in 7e3a263 while implementing #15. It was being given the originalException
argument of an ExceptionWrapper
-based exception. Whoops.
Reference in 24033ce was a typo. #21 was the correct ticket to be reference. The comment was corrected using git commit --amend
and git push --force
.
With
PropertyNotFoundException
being added as part of #15,getProperty()
'sexitOnFail
argument doesn't make a whole lot of sense.Ideas:
exitOnFail
argument togetProperty()
.__init__()
uses to set default properties toself.defaultProperties
instead ofself.properties
. Preserving our default properties will allow us to use them as a fallback.useDefault
flag togetProperty()
to replaceexitOnFail
. If true, then we will checkself.defaultProperties
. If this check fails, raisePropertyNotFoundException
.defaultOverride
flag togetProperty()
. If this is given a value, then we will not attempt to look throughself.defaultProperties
and instead just return this value.