Add rownames to dbMEM - Githubissues

adeverse / adespatial

Multivariate Multiscale Spatial Analysis

http://adeverse.github.io/adespatial/

34 stars 7 forks source link

Add rownames to dbMEM #12

Closed guiblanchet closed 4 years ago

guiblanchet commented 4 years ago

Through a question to a user, I noticed that row names were not included when constructing db-MEM. I added one line in the code to correct this.

sdray commented 4 years ago

Hi Guillaume,

this change introduces a bug in adespatial (examples in stimodel do no run now). Please, check the package afterr submitting a patch and before submitting to be sure that all CRAN check pass.

guiblanchet commented 4 years ago

Oups.. I just made the correction !

sdray commented 4 years ago

In fact, I think that we should use another way. Functions from spdep (e.g. dnearneigh, etc) allow to pass rownames but it is NULL by default. Hence, it would be better (and more general) to use rownames argument of dnearneigh. I updated in the master branch.