search

adevinta / spark-android

✨ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
58 stars 24 forks source link

BottomSheet display content bellow the system bar even when edge-to-edge is not active #1142

Open soulcramer opened 2 months ago

soulcramer commented 2 months ago

As reported here the BottomSheet doesn't take into account the windowInset.

image image

thomas-leguellec commented 2 months ago

https://adevinta.slack.com/archives/C04QQEU3Y2H/p1716999254230699

soulcramer commented 2 months ago

I replicate it on Spark Catalog app with E2E disabled. The next version of Material does fix this issue (and many others like the first one I mentioned in the thread). What should we do now as this is something we can’t fix on our side as the root cause is Material using a Popup impl to display the BottomSheet and they changed it to a Dialog impl in the next version to solve all their issues.

https://github.com/adevinta/spark-android/assets/11772084/2f27a9cd-cab1-4aab-a8d0-f454b703924b

https://github.com/adevinta/spark-android/assets/11772084/4b115843-ce11-46a5-bcd3-ddb3defbe9ce

soulcramer commented 2 months ago

We need to wait for M3 v1.3.0 to have this issue fixed