search

adevinta / spark-android

✨ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
58 stars 22 forks source link

feat(Divider): Add Divider component #1159

Closed kazaky closed 2 weeks ago

kazaky commented 1 month ago

📋 Changes

🤔 Context

Closes #1077

✅ Checklist

📸 Screenshots

🗒️ Other info

Summary by CodeRabbit

github-actions[bot] commented 1 month ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: dokka

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dokkaHtmlMultiModule 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

🚨 UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

github-actions[bot] commented 1 month ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.8 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.8 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

🚨 UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

github-actions[bot] commented 1 month ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
kazaky commented 1 month ago

@spark-ui-bot paparazzi

github-actions[bot] commented 3 weeks ago

🚨 UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

github-actions[bot] commented 3 weeks ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
github-actions[bot] commented 3 weeks ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.8 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.8 :x: Build Scan not published
kazaky commented 3 weeks ago

@soulcramer Done

kazaky commented 3 weeks ago

@coderabbitai summary

coderabbitai[bot] commented 3 weeks ago
Actions performed Summary regeneration triggered.
coderabbitai[bot] commented 3 weeks ago

Walkthrough

The overall change introduces a new Divider component with HorizontalDivider and VerticalDivider variants. This update involves renaming imports and usages from Divider to HorizontalDivider, adding divider customization options, creating new configurations and examples, removing deprecated dividers, and updating related documentation, tests, and examples.

Changes

File(s) Change Summary
.../configurator/component/Component.kt Renamed Divider to HorizontalDivider
.../configurator/samples/divider/DividerConfigurator.kt Added DividerConfigurator for divider customization
.../examples/divider/DividerExamples.kt Created examples for horizontal and vertical dividers
.../examples/example/Example.kt Refactored Example composable to support Row and Column layouts
.../samples/chips/ChipsExamples.kt Replaced Divider with MaterialHorizontalDivider
.../model/Components.kt Added new Divider component in inventory before Dropdowns; reordered imports
.../model/Example.kt Split content property into rowContent and columnContent
.../res/values/strings.xml Reordered annotations for existing texts; added new Divider description
.../divider/DividerScreenshot.kt Added tests for generating divider screenshots
.../components/divider/Divider.kt Deprecated old Divider; added new HorizontalDivider and VerticalDivider
.../components/divider/DividerIntent.kt Defined DividerIntent enum with options for divider colors
.../components/divider/divider.md Documented HorizontalDivider and VerticalDivider components
.../components/list/ListItem.kt Replaced Divider with HorizontalDivider in list item previews
.../components/menu/DropdownMenu.kt Replaced Divider with HorizontalDivider in DropdownMenuItem function
.../components/progress/tracker/ProgressTracker.kt Replaced custom dividers with MaterialHorizontalDivider and MaterialVerticalDivider
.../components/tab/TabGroup.kt Updated SparkDivider component to HorizontalDivider in TabGroup.kt
.../components/tab/TabRow.kt Updated SparkDivider to HorizontalDivider in SparkTabRow and ScrollableTabRow functions

Assessment against linked issues

Objective Addressed Explanation
Add and implement Divider and its variants (#1077) ✅
Add label support for dividers (#1077) ✅
Add screenshot testing (#1077) ✅
Add documentation for Divider (#1077) ✅
Add examples for dividers (#1077) ✅
Add new configurator (#1077) ❓ The configurator file is present, but its functionality implementation isn't clear.

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
kazaky commented 2 weeks ago

@soulcramer done

kazaky commented 2 weeks ago

@soulcramer Let's proceed forward