adevinta / spark-android

โœจ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
63 stars 24 forks source link

fix(modal): Allow ModalScaffold to take no buttons #1172

Closed soulcramer closed 3 months ago

soulcramer commented 3 months ago

๐Ÿ“‹ Changes

Hide the Bottom App Bar in the Modal when no actions are provided and in the Dialog layout I've also added the Close action so we still have a clear way to indicate that the Dialog can be closed with an action.

A new example screen as been added for testing.

๐Ÿค” Context

I didn't expect from the specs that the Modal could have no actions. This is now clarified so we need to hide the Bottom App Bar when no actions are provided.

Closes #1168

โœ… Checklist

๐Ÿ“ Other Info

I've added a private api to be able to combine 2 PaddingValues between each others and we may want to publish it in the future if it's not planned by Google ๐Ÿค”

github-actions[bot] commented 3 months ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dependencyGuard 8.7 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.7 :x: Build Scan not published
soulcramer commented 3 months ago

@spark-ui-bot spotless

github-actions[bot] commented 3 months ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: dokka

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dokkaHtmlMultiModule 8.7 :x: Build Scan not published
github-actions[bot] commented 3 months ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dependencyGuard 8.7 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.7 :x: Build Scan not published
github-actions[bot] commented 3 months ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dependencyGuard 8.7 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.7 :x: Build Scan not published
soulcramer commented 3 months ago

@spark-ui-bot spotless