adevinta / spark-android

โœจ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
58 stars 22 forks source link

fix(progresstracker): Indicator size now follow the font scaling #1173

Closed soulcramer closed 3 weeks ago

soulcramer commented 1 month ago

๐Ÿ“‹ Changes

Made the size of the indicator use scalable pixel instead of the density pixel unit so that the text inside will be visible and not clipped when the font is scaled

๐Ÿค” Context

The outline for the indicator had a fixed size which made the text label that could scale with font scaling clipped.

Closes #1027

โœ… Checklist

github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dependencyGuard 8.8 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.8 :x: Build Scan not published
soulcramer commented 1 month ago

@spark-ui-bot spotless

github-actions[bot] commented 1 month ago

๐Ÿšจ UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
soulcramer commented 1 month ago

@spark-ui-bot paparazzi golden images

soulcramer commented 1 month ago

The Icon size is broken

image
soulcramer commented 1 month ago

@spark-ui-bot paparazzi golden images