feat(dropdown): Add Dropdown overload of SelectTextField

soulcramer commented 1 month ago

📋 Changes

Wrap a Dropdown inside a Box to catch the pointer inputs and make the tap ripple nice with the TextField size.

🤔 Context

Allow for cases where items shown inside a Dropdown menu won't fit and need a larger display like a BottomSheet or another screen. This will avoid the Textfield from taking the focus.

Closes #1161

✅ Checklist

[x] I have reviewed the submitted code.
[x] I have tested on a phone device/emulator.

Summary by CodeRabbit

New Features
- Replaced SelectTextField with Dropdown across various configurators for a more streamlined and interactive UI.
Refactor
- Refactored several UI components to remove the onValueChange and readOnly properties from Dropdown.
Deprecation
- Deprecated the SelectTextField component in favor of the new Dropdown component.
Enhancements
- Improved the structure and functionality of dropdown-related UI elements.
- Introduced ExposedDropdownMenuBox and DropdownMenu components for enhanced dropdown functionality.
Tests
- Updated test cases to reflect changes from SelectTextField to Dropdown.

kazaky commented 3 weeks ago

@coderabbitai summary

coderabbitai[bot] commented 3 weeks ago

Actions performed

Summary regeneration triggered.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The updates primarily involve replacing the SelectTextField component with the Dropdown component across various Kotlin files. This change impacts the way dropdown functionalities are implemented, enhancing UI elements and encapsulating new features like tappable dropdown menus. Several properties and parameters were also adjusted, such as the removal of onValueChange and readOnly.

Changes

Files Affected	Change Summary
`catalog/.../BottomSheetConfigurator.kt`, `catalog/.../ButtonsConfigurator.kt`,	Replaced `SelectTextField` with `Dropdown`, removed `onValueChange` and `readOnly` properties.
`catalog/.../IconButtonsConfigurator.kt`, `catalog/.../IconToggleButtonsConfigurator.kt`,	Replaced `SelectTextField` with `Dropdown`, removed `onValueChange` parameters.
`catalog/.../popover/PopoverConfigurator.kt`, `catalog/.../progressbar/ProgressbarConfigurator.kt`	Replaced `SelectTextField` with `Dropdown`, removed `onValueChange` and `readOnly` properties.
`catalog/.../progresstracker/ProgressTrackerConfigurator.kt`, `catalog/.../slider/SliderConfigurator.kt`	Replaced `SelectTextField` with `Dropdown`, modified relevant parameters.
`catalog/.../tabs/TabsConfigurator.kt`, `catalog/.../text/TextLinkConfigurator.kt`	Replaced `SelectTextField` with `Dropdown`, removed `onValueChange` and `readOnly` properties, adjusted `label` property.
`catalog/.../textfields/ComboBoxConfigurator.kt`	Added `@Suppress("DEPRECATION")` before `SelectTextField` declaration in `ComboBoxSample` function.
`catalog/.../toggles/CheckboxConfigurator.kt`, `catalog/.../toggles/RadioButtonConfigurator.kt`	Replaced `SelectTextField` with `Dropdown`, removing `onValueChange` and adjusting properties where relevant.
`catalog/.../SwitchConfigurator.kt`	Replaced `SelectTextField` with `Dropdown`, affecting UI elements related to switch samples.
`catalog/.../themes/ThemePicker.kt`	Replaced `SelectTextField` with `Dropdown`, removed `readOnly` and `onValueChange`.
`spark-screenshot-testing/.../TextFieldDocScreenshot.kt`	Added `ExperimentalSparkApi` import, replaced `SelectTextField` with `Dropdown`, and updated function calls accordingly.
`spark/.../menu/DropdownMenu.kt`	Added `DropdownMenuGroupItem` and `SectionHeadline` composable functions; updated `DropdownMenuItemPreview` with changes.
`spark/.../textfields/AddonScope.kt`	Removed `enabled` parameter from `SparkSelectTrailingIcon`, retaining only `expanded` parameter.
`spark/.../textfields/Dropdown.kt`	Renamed `SelectTextField` to `Dropdown`, deprecated old component, introduced `ExposedDropdownMenuBox`, `DropdownMenu` components.

Assessment against linked issues

Objective	Addressed	Explanation
#1161: Provide tappable dropdown version	✅

[!TIP]

Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

kazaky commented 3 weeks ago

@coderabbitai review

github-actions[bot] commented 3 weeks ago