feat(Dropdown): Add custom item support examples

soulcramer commented 3 weeks ago

📋 Changes

Add Custom items examples and improve the configurator to actually represent the selection when an item is tapped. Also fix the Dropdown showing the menu while the Textfield is not enabled.

🤔 Context

Close #1163

✅ Checklist

[x] I have reviewed the submitted code.
[x] I have tested on a phone device/emulator.
[x] If it includes design changes, please ask for a review spark-design GitHub team.

🗒️ Other info

A11y need some fixes in the examples

Summary by CodeRabbit

New Features
- Introduced new DropdownMenuGroupItem component for dropdown groups.
- Added new custom dropdown item examples (Single/Multi-Select, Custom Items).
Enhancements
- Improved text element styling with new highlight style.
- Updated dropdown text field state message styling.
- Refactored dropdown examples into separate composable functions.
Bug Fixes
- Prevented menu expansion when the text field is disabled.
- Adjusted progress indicator mappings for better Spark compatibility.
Refactor
- Reformatted class declarations for better readability.
- Removed unnecessary imports and reorganized component structure.

soulcramer commented 2 weeks ago

I don't know what happened here 🤔 , I only rebased from main and run spotless

kazaky commented 2 weeks ago

@coderabbitai review

kazaky commented 2 weeks ago

@coderabbitai summary

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The update focuses on refining the styling and structure of dropdown elements across various components within the catalog application. Major changes involve introducing new imports, refactoring dropdown examples into composable functions, and modifying text field behavior. These enhancements aim to streamline dropdown functionalities, improve the user interface, and align with design standards.

Changes

Files/Directories	Change Summary
`ComboBoxConfigurator.kt`	Imported `highlight` and updated text style from `fontWeight = FontWeight.Bold` to `highlight`.
`DropdownsConfigurator.kt`	Added imports for dropdowns, immutable collections, and provided new data class and sample data for dropdown groups.
`DropdownExamples.kt`	Introduced new composable functions for single and multi-selection dropdowns, and custom items dropdown, along with necessary imports.
`MaterialComposableUsageDetector.kt`	Reformatted class definition and adjusted mapping for progress indicators to Spark replacements.
`DropdownMenu.kt`	Added import for `FontStyle` and modified `SectionHeadline` function to set font style to italic.
`AddonScope.kt`	Removed certain imports and reorganized the `TextFieldWithDropdownPreview` function by removing the `Box` wrapper.
`Dropdown.kt`	Adjusted modifier usage in `SelectTextField`, added a conditional check in `Dropdown` to prevent menu expansion when the TextField is disabled.

Sequence Diagram(s)

N/A

Assessment against linked issues

Objective	Addressed	Explanation
Add remaining examples for dropdown component (#1163)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 2 weeks ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
spark-android	dependencyGuard	8.8	:white_check_mark:
spark-android	spotlessCheck :build-logic:spotlessCheck	8.8	:x:

github-actions[bot] commented 2 weeks ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
spark-android	dependencyGuard	8.8	:white_check_mark:
spark-android	spotlessCheck :build-logic:spotlessCheck	8.8	:x:

soulcramer commented 2 weeks ago

@spark-ui-bot spotless

kazaky commented 1 week ago

@spark-ui-bot paparazzi

github-actions[bot] commented 1 week ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
spark-android	dependencyGuard	8.8	:white_check_mark:
spark-android	spotlessCheck :build-logic:spotlessCheck	8.8	:x:

github-actions[bot] commented 1 week ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
spark-android	dependencyGuard	8.8	:white_check_mark:
spark-android	spotlessCheck :build-logic:spotlessCheck	8.8	:x:

github-actions[bot] commented 1 week ago

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
spark-android	dependencyGuard	8.8	:white_check_mark:
spark-android	spotlessCheck :build-logic:spotlessCheck	8.8	:x:

soulcramer commented 1 week ago

@spark-ui-bot spotless

adevinta / spark-android