adevinta / spark-android

✨ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
58 stars 22 forks source link

fix: Snackbar not showing #1197

Closed kazaky closed 2 weeks ago

kazaky commented 2 weeks ago

📋 Changes

QA reported Snackbar was not showing, actually it was showing but immediately gets disappeared, due to action dismiss gets called.

I removed this line. now works well

🤔 Context

✅ Checklist

📸 Screenshots

🗒️ Other info

github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$
github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$
github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$
github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$
github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$
github-actions[bot] commented 2 weeks ago

🔣 PR title format


commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Fix: Fix Snackbar host not showing"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$