adevinta / spark-android

โœจ Simple, Modular & Accessible UI Components for your Android Applications
https://adevinta.github.io/spark-android/
MIT License
63 stars 24 forks source link

feat: Add support to feature flags #1265

Closed soulcramer closed 1 month ago

soulcramer commented 1 month ago

๐Ÿ“‹ Changes

Extract the flags from the SparkTheme Composable to a data class.

๐Ÿค” Context

As I want to add more debugging flags in the future it would have made the SparkTheme Composable more complex than necessary so I extracted them . This change made it easier to add these flags in the catalog app for testing as well.

โœ… Checklist

๐Ÿ“ธ Screenshots

image image

github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: validation

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android dependencyGuard 8.8 :white_check_mark: Build Scan not published
spark-android spotlessCheck :build-logic:spotlessCheck 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
github-actions[bot] commented 1 month ago

๐Ÿšจ UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published
SimonMarquis commented 1 month ago

@soulcramer something changed and forced a white background in screenshot tests. Can you take a look at this and remove it?

soulcramer commented 1 month ago

Oh I know the issue, I didn't noticed it in Github in light mode ๐Ÿซ 

github-actions[bot] commented 1 month ago

Job Summary for Gradle

๐Ÿ‘ท Build โ†’ ๐Ÿง‘โ€๐Ÿ”ฌ Test โ†’ ๐Ÿ•ต๏ธ Lint :: build-test-lint

Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scanยฎ
spark-android assembleRelease 8.8 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.8 :x: Build Scan not published