adevinta / spark-ios

✨ Simple, Modular & Accessible UI Components for your iOS Applications
MIT License
17 stars 4 forks source link

[Rating] Correct accessibility attributes #1007

Open michael-zimmermann opened 1 month ago

michael-zimmermann commented 1 month ago

In the SwiftUI Rating Display & Input the accessibilityIdentifier needs to be set after the accessibilityElement In both SwiftUI and UIKit of the Rating Display accessibility value should be set to the current rating value (without the "/") In both SwiftUI and UIKit the Rating Input accessibility value should be set to a value as a whole number (e.g. 2 instead of 2.0) UIKit: Rating value not set correctly on initialization SwiftUI: Rating value should be whole number the same as in UIKit