adevinta / spark

✨ Simple, Modular & Accessible UI Components for your React Applications
https://sparkui.vercel.app
MIT License
51 stars 16 forks source link

feat(combobox): improved UX of default combobox filtering behaviour #2184

Closed Powerplex closed 1 month ago

Powerplex commented 1 month ago

TASK: #2183

Description, Motivation and Context

  1. Read attached issue.
  2. Proposal is to replace autoFilter (boolean), by filtering: "auto" | "none" | "strict"

strict matches the previous default behaviour, auto is the new/improved way for filtering, where the filtering only applies once the user starts typing.

For example, if the user selects a value in the list, it will reset/cancel the filtering so they can explore the full list of values.

Types of changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.63%. Comparing base (3c579e7) to head (cb5e97f). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2184 +/- ## ======================================= Coverage 97.63% 97.63% ======================================= Files 749 749 Lines 5880 5884 +4 Branches 2105 2075 -30 ======================================= + Hits 5741 5745 +4 Misses 137 137 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.