search

adevinta / spark

✨ Simple, Modular & Accessible UI Components for your React Applications
https://sparkui.vercel.app
MIT License
70 stars 20 forks source link

fix(select): fix disabled and readonly styles #2198

Closed soykje closed 3 months ago

soykje commented 4 months ago

TASK: #2136

Description, Motivation and Context

On the Select component disabled and readOnly states seem to be desync with input styles. We want to harmonize and fix this.

Types of changes

Screenshots - Animations

image image

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.63%. Comparing base (cef5c53) to head (720094b). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2198 +/- ## ======================================= Coverage 97.63% 97.63% ======================================= Files 749 749 Lines 5885 5885 Branches 2107 2076 -31 ======================================= Hits 5746 5746 Misses 137 137 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.