search

adevinta / spark

✨ Simple, Modular & Accessible UI Components for your React Applications
https://sparkui.vercel.app
MIT License
51 stars 16 forks source link

[Component] - Snackbar #2199

Closed acd02 closed 2 weeks ago

acd02 commented 1 month ago

If you watch the video below, you will understand the bug. Essentially, if you slightly swipe the snackbar without swiping enough to close it, the onClose button fails to close the snackbar.

Additionally, the timeout function that should automatically close the snackbar after 5 seconds also becomes inactive. When in this state, the only way to close the snackbar is to swipe it

Image

soykje commented 2 weeks ago

@elisa-hery Ready for QA time: https://spark-ui-uhip-n4q4w74h4-sparkteams-projects.vercel.app/iframe.html?id=components-snackbar--close&viewMode=story 🙏

elisa-hery commented 2 weeks ago

@soykje I tested all these cases on safari web / safari mobile / chrome web : it's all good, this bug is fixed ✅

Nevertheless it made me notice 2 things :

  1. on safari (Version 17.4.1), with keyboard navigation, enter or space don't trigger action or close button (I know you cannot work on safari, but at least maybe I should show you)
  2. with a long text in the action button, the button takes the whole space (and also it's not vertically aligned), and I'm not sure this is what we want : Screenshot 2024-06-18 at 11 30 45

maybe we can talk about this !

elisa-hery commented 2 weeks ago
  1. we created a new task for this --> https://github.com/adevinta/spark/issues/2249
  2. @soykje fixed it ✅