adevinta / spark

✨ Simple, Modular & Accessible UI Components for your React Applications
https://sparkui.vercel.app
MIT License
70 stars 20 forks source link

fix(snackbar): fixes and improves snackbar swipe styles to avoid translate collision #2223

Closed soykje closed 3 months ago

soykje commented 3 months ago

TASK: #2199

Description, Motivation and Context

Snackbar animations (with translate property) were having edge case issue with collission between different data attributes bringing their own translate rule.

Types of changes

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.56%. Comparing base (bef11fc) to head (fe176ab). Report is 4 commits behind head on main.

Files Patch % Lines
packages/components/snackbar/src/useSwipe.ts 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2223 +/- ## ======================================= Coverage 97.56% 97.56% ======================================= Files 760 760 Lines 6006 6007 +1 Branches 2136 2100 -36 ======================================= + Hits 5860 5861 +1 Misses 144 144 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.