adevinta / spark

โœจ Simple, Modular & Accessible UI Components for your React Applications
https://sparkui.vercel.app
MIT License
49 stars 16 forks source link

fix(dialog): adjust the handling of the hasCloseButton flag to avoid a potential infinite loop with React 19 #2261

Closed acd02 closed 1 week ago

acd02 commented 1 week ago

fix(dialog)

Description, Motivation and Context

Adjust the handling of the hasCloseButton flag to avoid a potential infinite loop with React 19

Types of changes

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.56%. Comparing base (c957f90) to head (9a6db95). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2261 +/- ## ========================================== - Coverage 97.56% 97.56% -0.01% ========================================== Files 760 760 Lines 6008 6001 -7 Branches 2138 2137 -1 ========================================== - Hits 5862 5855 -7 Misses 144 144 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.