adevinta / zoe

The Kafka CLI for humans
https://adevinta.github.io/zoe
MIT License
286 stars 21 forks source link

Add schema/subject deletion commands #48

Closed LouisVN closed 2 years ago

LouisVN commented 2 years ago

This PR aims to add the following capabilities to the CLI:

Some docs were added in the related guide.

LouisVN commented 2 years ago

Hi @wlezzar!

The toggle to delete a schema version vs subject is based on the presence of the --schema-version flag. Feel free to suggest a better approach as this might not be the most elegant way to do this :smiley:

wlezzar commented 2 years ago

Amazing contribution @LouisVN : ) . Thanks a lot.

There are very minor feedbacks that I will provide shortly but the PR seems excellent for me overall! 👍🏼

wlezzar commented 2 years ago

@LouisVN I just tested it, it looks great 👍🏼 🚀

One last thing I noticed while testing:

> zoe --silent schemas delete input-events-topic-value --dry-run

{"type":"dry","subject":"input-events-topic-value","version":"version","hardDelete":"soft delete"}

I find this part in the response a bit confusing: "hardDelete":"soft delete". Can you make it rather: "hardDelete":false?

When this last change is done, we will be ready to ship it and create a new release 😉

wlezzar commented 2 years ago

Approved 🎉 🚀 . Let me know when you are ok to merge?

LouisVN commented 2 years ago

Thanks a lot! :tada: Go ahead and merge it if everything's fine for you :smiley:

wlezzar commented 2 years ago

Merged! Thanks to you for the contribution ; )