Closed LouisVN closed 2 years ago
Hi @wlezzar!
The toggle to delete a schema version vs subject is based on the presence of the --schema-version
flag. Feel free to suggest a better approach as this might not be the most elegant way to do this :smiley:
Amazing contribution @LouisVN : ) . Thanks a lot.
There are very minor feedbacks that I will provide shortly but the PR seems excellent for me overall! 👍🏼
@LouisVN I just tested it, it looks great 👍🏼 🚀
One last thing I noticed while testing:
> zoe --silent schemas delete input-events-topic-value --dry-run
{"type":"dry","subject":"input-events-topic-value","version":"version","hardDelete":"soft delete"}
I find this part in the response a bit confusing: "hardDelete":"soft delete"
. Can you make it rather: "hardDelete":false
?
When this last change is done, we will be ready to ship it and create a new release 😉
Approved 🎉 🚀 . Let me know when you are ok to merge?
Thanks a lot! :tada: Go ahead and merge it if everything's fine for you :smiley:
Merged! Thanks to you for the contribution ; )
This PR aims to add the following capabilities to the CLI:
Some docs were added in the related guide.