search

adewes / blitzdb

Blitz is a document-oriented database for Python that is backend-agnostic. It comes with a flat-file database for JSON documents and provides MongoDB-like querying capabilities.
http://blitzdb.readthedocs.org
MIT License
330 stars 37 forks source link

Pep8 #22

Closed dmytrokyrychuk closed 10 years ago

dmytrokyrychuk commented 10 years ago

Just passed source code through autopep8 plus edited some places by hand. There is still a lot of unresolved inspections:

(blitzdb)orgkhnargh@mint:~/code/blitzdb > find ./blitzdb -name '*.py' -exec pep8 {} \; | wc -l
516

Especially there is a lot of too long lines (length > 79). I could fix that since it is easy enough for me. Are you guys interested in this kind of help? Seems I didn't beak anything. Pytest summary: 113 passed, 2 skipped, 7 error in 9.16 seconds. Same as at master branch.

adewes commented 10 years ago

Hey Dima,

that's really great, I'm totally interested in your help improving the style and code conventions in BlitzDB! In fact, I'm working on an online solution for code quality management where you can see various linter results for BlitzDB (pep8,pylint, pyflakes, ...) online:

http://alpha.quantifiedcode.com/?#/project/gh:adewes:blitzdb

It's still an early alpha but I'll hope to release a full version for public use soon.

Concerning the line lengths I think it's a good idea to shorten the longest ones, although I'm not very strict when it comes to the 80 character limit (since with screen resolutions these days you can easily view 120 - 160 characters per line).

Cheers Andreas

2014-07-14 16:08 GMT+02:00 Dima Kyrychuk notifications@github.com:

Just passed source code through autopep8 plus edited some places by hand. There is still a lot of unresolved inspections:

(blitzdb)orgkhnargh@mint:~/code/blitzdb > find ./blitzdb -name '*.py' -exec pep8 {} \; | wc -l 516

Especially there is a lot of too long lines (length > 79). I could fix that since it is easy enough for me. Are you guys interested in this kind of help? Seems I didn't beak anything. Pytest summary: 113 passed, 2 skipped, 7

error in 9.16 seconds. Same as at master branch.

You can merge this Pull Request by running

git pull https://github.com/orgkhnargh/blitzdb pep8

Or view, comment on, or merge it at:

https://github.com/adewes/blitzdb/pull/22 Commit Summary

  • fixed pep8 E231 inspections
  • fixed pep8 E203 inspections
  • fixed pep8 E201 inspections
  • fixed pep8 E203 inspections
  • fixed pep8 E265 inspections
  • fixed pep8 E251 inspections
  • fixed pep8 E226 inspections
  • fixed pep8 E225 inspections
  • fixed pep8 E241 inspections
  • fixed pep8 E301, E302, E303 inspections
  • fixed pep8 E713 inspections
  • fixed pep8 E262 inspections
  • fixed pep8 E228 inspections
  • fixed pep8 E222 inspections
  • fixed more pep8 E222 inspections
  • fixed pep8 W391 inspections
  • fixed pep8 E271 inspections
  • fixed pep8 E126, E128 inspections
  • fixed pep8 E123 inspections
  • fixed pep8 E221 inspections

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/adewes/blitzdb/pull/22.

adewes commented 10 years ago

Thanks Dmytro, just merged the changes into master :+1:

dmytrokyrychuk commented 10 years ago

I like to have two files open at a time: first one on the left half of screen and second one on the right half. Usually I have to scroll left/right to read those files which have some lines longer than 80 chars. That is why I am trying to respect that line length rule. I will make some more commits later with fixes of pep8 E501 inspection.

adewes commented 10 years ago

Great, thanks Dmytro!

2014-07-19 13:04 GMT+02:00 Dmytro Kyrychuk notifications@github.com:

I like to have two files open at a time: first one on the left half of screen and second one on the right half. Usually I have to scroll left/right to read those files which have some lines longer than 80 chars. That is why I am trying to respect that line length rule. I will make some more commits later with fixes of pep8 E501 inspection.

— Reply to this email directly or view it on GitHub https://github.com/adewes/blitzdb/pull/22#issuecomment-49506492.