adewg / ICAR

Standard messages and specifications for animal data exchange in livestock.
https://icar.org/
Apache License 2.0
49 stars 26 forks source link

Address Speccy and Spectral linting errors and warnings #313

Closed cookeac closed 2 years ago

cookeac commented 2 years ago

There were a number of Speccy and Spectral errors and warnings that are worth looking into now that Spectral is running again. In this pull request I've addressed some of these:

There are still errors about "type" property must be equal to one of the allowed values: "array", "boolean", "integer", "number", "object", "string". in a number of collection files. This seems to be spurious, and indeed when I reproduce this by running Spectral locally in the VS Code extension, when it hits one of these Spectral stops with an error and directs me to look at its output. The actual JSON Schema looks correct - there is an array, and the error occurs at the start of the "items" clause, not in the "type" clause. It doesn't even work if items is a simple type.

cookeac commented 2 years ago

Approved at meeting