search

adewg / ICAR

Standard messages and specifications for animal data exchange in livestock.
https://icar.org/
Apache License 2.0
47 stars 26 forks source link

Testing patch release 1.3.2 prior to release #364

Closed cookeac closed 1 year ago

cookeac commented 1 year ago

Hi everyone,

As many of you will know, after the release of 1.3 (and the fix to withholding event in 1.3.1) a few more problems were discovered with ADE 1.3. These were:

353 Problem with icarStatistics

357 AnyOf causes problem with code generation in icarConsignmentType origin and destination addresses.

We also resolved we needed release notes to explain the discriminator changes in 1.3. (#358). I have put this in a release notes MD and link to it from the main readme. I added some text to explain the fixes above.

We believe we have now addressed the above with commits to the branch https://github.com/adewg/ICAR/tree/RC-for-ADE-1-3-2 We would like to test this promptly so it can be released. If you have access to code generation tools, can you please test this branch and report your results so we can merge the branch into both ADE1 (new release 1.3.2) and back into the Develop branch.

Thanks, Andrew.

cookeac commented 1 year ago

Adding developers with C# and Java, let me know if you haven't got time.

AlexeyHardCode commented 1 year ago

C# code generation looks just as expected: image

Also icaStatisticType model code generation is valid.

AndreasSchultzGEA commented 1 year ago

Java-Code for Consignment seems to be ok. The code for IcarStatisticType could not be testet, as we don't have implemented this parts so far.

PostalAdress