Tested changes for ADE 1.3.2

adewg / ICAR

Standard messages and specifications for animal data exchange in livestock.

https://icar.org/

Apache License 2.0

49 stars 26 forks source link

Tested changes for ADE 1.3.2 #367

Closed cookeac closed 1 year ago

cookeac commented 1 year ago

This pull request integrates the following changes:

Repairs to the icarStatisticsResource and related resources - resolves #353
Revert 1.3 changes to icarConsignmentType address fields - resolves #357
Added an explanation for ADE 1.3 changes around discriminators - resolves #358
Testing C# and Java code generation for this patch release - resolves #364

cookeac commented 1 year ago

This has already been reviewed by the technical working group, but our process requires a review, so linking in @erwinspeybroeck for a quick approval.

erwinspeybroeck commented 1 year ago

in the milkUrlScheme: "operationId": "get existing milking-withdrawals", should be "operationId": "get-existing-milking-withdrawals",

Rest is ok for me

cookeac commented 1 year ago

Correction made.