search

adfinis / ember-simple-auth-oidc

ember-simple-auth authenticator for the OpenID Connect standard
GNU Lesser General Public License v3.0
22 stars 18 forks source link

4.1.0 breaks application that do not use apollo client #597

Open wmlele opened 2 years ago

wmlele commented 2 years ago

Upgrading to 4.1.0 breaks build of my applications:

ember-simple-auth-oidc tried to import "@apollo/client" in "ember-simple-auth-oidc/apollo.js" but the package was not resolvable from /storage/workspaces/leaf/leaf-sign/node_modules/ember-simple-auth-oidc

Is it intended? is ember-simple-auth-oidc going to require apollo?

anehx commented 1 year ago

Thank you for creating an issue for this @wmlele !

This is not intended. @apollo/client should be an optional peer dependency as specified here: https://github.com/adfinis/ember-simple-auth-oidc/blob/3c69b18222cbe4e296655f398221208b456867e8/package.json#L83-L90

I'll take a look at it to figure out why this is causing an error..

anehx commented 1 year ago

This might be a bug of embroider, I created an issue: https://github.com/embroider-build/embroider/issues/1266

For now, we might have to make @apollo/client a dependency to resolve this issue..

anehx commented 1 year ago

This is temporarly fixed in v5.0.1 with #685. However, I'm gonna leave this issue open since we need to revert that PR as soon as embroider fixes its issue.

bjornharrtell commented 1 year ago

FWIW I still need to add graphql as deps to get the build to work with v5.0.3.