adfinis / ember-uikit

The ember implementation of UIkit

https://adfinis.github.io/ember-uikit/

MIT License

26 stars 13 forks source link

Fastboot Compatibility? #10

Open jayvarner opened 6 years ago

jayvarner commented 6 years ago

I don't know if y'all are interested in this, but I'm going to make a PR.

Currently, running ember-uikit in fastboot throws an error due to document not being defined in fastboot.

Thanks for getting this wrapper started. I'm looking forward to contributing more.

anehx commented 6 years ago

As discussed in #11, this is definitely something we want to support. We also should add tests (https://github.com/kaliber5/ember-fastboot-addon-tests) for this to ensure full compatibility.

We look forward to you contributing to this project!

anehx commented 6 years ago

By the way: How did you find this addon? Do you have any use cases for this yet?

jayvarner commented 6 years ago

Hey, I'm happy to add the tests. I wanted to make sure y'all were interested before I went too far.

I found the addon via Google. I'm rebuilding a hybrid Ember app and UIKit seemed like a good fit. I have started implementing some more components and will contribute back as I finish them up.

anehx commented 6 years ago

14 adds fastboot compatibility so the only thing which is still missing is fastboot tests

jayvarner commented 6 years ago

Sorry I totally ghosted on this. I didn't have much luck with fastboot-addon-tests. FWIW, i got the same errors trying to run the fastboot tests in ember-bootstrp. I'm clearly doing something wrong or something isn't configured right. Sorry, I just haven't had time to fight with it again.