fix(modifiers): ensure modifier compatibility with the new modifier API

adfinis / ember-uikit

The ember implementation of UIkit

https://adfinis.github.io/ember-uikit/

MIT License

26 stars 13 forks source link

fix(modifiers): ensure modifier compatibility with the new modifier API #932

Closed anehx closed 2 years ago

anehx commented 2 years ago

Wouldn't this be a breaking change as we dont use the positional modifiers? https://github.com/ember-modifier/ember-modifier/blob/master/MIGRATIONS.md#when-is-this-a-breaking-change In register-uikit-events.js

The register-uikit-events modifier is not public API. We only use it internally which is why I would say no, this is not breaking.

anehx commented 2 years ago

:tada: This PR is included in version 6.1.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: