feat(modal): convert modal logic to modifier

adfinis / ember-uikit

The ember implementation of UIkit

https://adfinis.github.io/ember-uikit/

MIT License

26 stars 13 forks source link

feat(modal): convert modal logic to modifier #934

Closed anehx closed 2 years ago

anehx commented 2 years ago

Moving the modal logic to a modifier has the advantage of not needing the ember and mutation observers and the dependency on @ember/render-modifiers.

Consuming apps that needed to enable the default-async-observers for modals to work should be able to disable it now.

anehx commented 2 years ago

:tada: This PR is included in version 6.1.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: