search

adfinis / helm-charts

📈 Helm charts from Adfinis
GNU Affero General Public License v3.0
63 stars 44 forks source link

[keycloak-operator] Customize namespace by property #1273

Open gwydionmv opened 3 months ago

gwydionmv commented 3 months ago

Is your feature request related to a problem? Please describe. The current keycloak-operator chart doesn't allow to specify the namespace for the resources.

Describe the solution you'd like Include in the metadata section of every resource a new line like namespace: {{ include "keycloak-operator.operator.namespace" . }}

hairmare commented 3 months ago

tbh, i never understood the namespace: ... pattern that most charts started using at some point. Do you by any chance know why it's needed? I've never had to use it when installing this chart because doing it via Argo CD or using helm install --namespace <ns> seems to work all the time.

I'll gladly merge it if it's really needed, maybe it should be optional?

{{- with .Values.keycloak.namespace }}
  namespace: {{ . }}
{{- end }}
gwydionmv commented 3 months ago

well, we use it because we have different namespaces name depending on the environment, so to automatise the generation and deployment during the CI/CD we need to be able to customise it (we are not using ArgoCD).

I completely agree with the optional line :D

gwydionmv commented 3 months ago

I have already push a PR with the changes :D

https://github.com/adfinis/helm-charts/pull/1274