search

adfinis / openshift-etcd-backup

CronJob to perform an etcd backup inside an OpenShift cluster
GNU Affero General Public License v3.0
17 stars 18 forks source link

[feature] Add support for S3 storage #55

Closed abdennour closed 9 months ago

abdennour commented 1 year ago

Hi , please suppport backup to S3 bucket! Let's design it together: OCP_BACKUP_S3_ENDPOINT OCP_BACKUP_S3_BUCKET OCP_BACKUP_S3_ACCESS_KEY_ID OCP_BACKUP_S3_SECRET_KEY OCP_BACKUP_S3_REGION=us-east-1

tongpu commented 1 year ago

This would require some changes to the current script (e.g. find and ls would not be sufficient for cleanup anymore) and add additional dependencies (e.g. AWS CLI or some other S3 client). We currently don't have a use-case where S3 would be required, but we would be happy to accept a PR if you're willing to introduce the feature.

tongpu commented 9 months ago

Closing this feature request because of no activity.

vmaillot commented 5 months ago

@abdennour you should be able to use the S3 support with this version.

We suggest you to use the helm chart associated: https://github.com/adfinis/helm-charts/tree/main/charts/openshift-etcd-backup

I'm on my way to add the custom CA support with OpenShift for TLS with MinIO.

abdennour commented 5 months ago

That's awesome @vmaillot ! Will give you review