Open StephanH90 opened 8 months ago
anehx
commented
8 months ago A nicer solution would be to track the selection of the reports in the url, but that could potentially break a lot of business logic.
Actually it is tracked but if the bulk edit is canceled we don't pass it on.. That would be a nice feature but I also like this solution!
However, I'm not sure if we need to use a separate color if the "needs review"-report is selected..
derrabauke
commented
8 months ago Actually the selection was remaining until we have refactored the whole app/analysis controller and by doing that the feature got lost.
Will try to restore that functionality!
derrabauke
commented
8 months ago Will try to restore that functionality!
Done here https://github.com/adfinis/timed-frontend/pull/1187
StephanH90
commented
8 months ago @derrabauke the real MVP.
I routinely select a bunch of rows during review, click "edit selected reports" and then realise that i cant verify them because one of them had the review flag set and now i need to reselect them all.
This is an attempt to alleviate this pain:
A nicer solution would be to track the selection of the reports in the url, but that could potentially break a lot of business logic.
I'm also aware that highlighting with colour might not be the best for colour-blind people etc. so any suggestion on how to do it better is welcome. However, I think the current little tick on the right side is too small (because I am focused on the left part of the table)