search

adh-partnership / api

Apache License 2.0
1 stars 1 forks source link

Backend support for recording event late/miss #166

Closed Celeo closed 1 year ago

Celeo commented 1 year ago

In partial service of #321 if the EC is okay only having the in-built tracking and not the automatic barring of event-signup.

dhawton commented 1 year ago

Why make it so specialized? I'd rather see a generic staff set of action logs similar to the division's than create this while elaborate thing for such a minor task. If we're going to do this really specialized thing, feature flag please so partners can opt out. I feel having a more generalized staff note would be beneficial.

Celeo commented 1 year ago

Why make it so specialized?

Because that's what was asked for. If other members of staff want something generic, then they can ask for it.

dhawton commented 1 year ago

Why make it so specialized?

Because that's what was asked for. If other members of staff want something generic, then they can ask for it.

Then it becomes less useful... so feature flag it please. Sometimes making something more general is better even when not asked for if it can be more beneficial to more people. Sometimes users don't know what to ask for.

dhawton commented 1 year ago

It might help to have design discussions before doing work that is larger in scale and impacting of more than ZDV so we can discuss items like this before work is done.

Celeo commented 1 year ago

Sometimes users don't know what to ask for

Thankfully, you know better.

If I wanted to spend time guessing what users want, I would become a Project Manager.

dhawton commented 1 year ago

Sometimes users don't know what to ask for

Thankfully, you know better.

If I wanted to spend time guessing what users want, I would become a Project Manager.

Hence why I am in the ZDV discord still, so we can have discussions on implementations. The logic here is flawed. Firstly, you're only implementing counters, and exposing this to non-authed users and non-staff. This kind of data shouldn't be public. Secondly, is the expectation that the EC remember after X days to go and decrement the "offense"? Lastly, if there are 3 tardies or no-shows, are they from the last week, month, year? A more generic action log allows the EC to say "Late for X event" and it would be timestamped via the created_at field, and it could be used for other purposes as well outside of just events.