search

adham-elarabawy / open-quadruped

An open-source 3D-printed quadrupedal robot. Intuitive gait generation through 12-DOF Bezier Curves. Full 6-axis body pose manipulation. Custom 3DOF Leg Inverse Kinematics Model accounting for offsets.
https://adhamelarabawy.com
Other
365 stars 68 forks source link

Restructured Dir for ROS #8

Closed adham-elarabawy closed 4 years ago

adham-elarabawy commented 4 years ago

I realized that my previous dir structure meant that I was uploading my catkin workspace to github. This is completely unnecessary and confusing for anyone trying to replicate my project. So, I decided to do a major restructuring of my repository to facilitate ROS usage.

caelinsutch commented 4 years ago

Just a heads up, it is considered best practice for projects to have a root catkin_ws for the packages. I've also noticed that you decided to go with one big package for everything. I recommend breaking down the codebase into multiple packages.

For example, the ROV MIND repository has a dedicated ros_ws that houses seperate packages, such as global launch files, various hardware interfaces, and other code functions.

In Bytes Robotics we have around 6 packages for our main robot that are ours, and 8 or so that we build from forks.

adham-elarabawy commented 4 years ago

@caelinsutch That's a good point. I'm only using 1 custom package though (all of the other packages are installed via apt-get), so it seems to be cleaner to have my repo be the package. What do you think?

adham-elarabawy commented 4 years ago

@caelinsutch Actually, I heeded your advice and restructured my repo again to follow the format you outlined. Thanks for the tip!