search

adhearsion / adhearsion-asterisk

Asterisk specific features for Adhearsion
http://adhearsion.com
MIT License
17 stars 15 forks source link

Update play_time to explicitly send the default time format. Older aster... #14

Open vindir opened 11 years ago

vindir commented 11 years ago

...isk versions won't handle dangling nil arguments.

benlangfeld commented 11 years ago

For which versions of Asterisk does the old behaviour not work?

benlangfeld commented 11 years ago

In Asterisk 1.8+ the default format will be used if no format is specified. I think it's better to not send the format (as opposed to sending '') rather than override a default here.

vindir commented 11 years ago

Hey Ben, the asterisk version in question is the default install on Rackspace's image of Ubuntu 12.04.

We could have the application to force a default on the timezone, but this error fails silently and it's on a pretty common distribution. If you'd rather not force a default still, is there some way we can track success/failure on sayunixtime calls to give some feedback to the user?

bklang commented 11 years ago

I agree with @benlangfeld about not supplying a default format. If the format isn't specified, we should simply not send the empty commas.