search

adhearsion / adhearsion-drb

adhearsion-drb is an Adhearsion Plugin providing DRb connectivity. It allows third party ruby clients to connect to an Adhearsion instance for RPC.
MIT License
10 stars 4 forks source link

Restart the DRB service when it completes it’s thread #7

Closed JustinAiken closed 10 years ago

JustinAiken commented 10 years ago

Unless it’s explicitly stopped by the user

JustinAiken commented 10 years ago

Rebased with changelog and specs... should be ready to merge now, pending your review @benlangfeld

JustinAiken commented 10 years ago

Hmm, travis says no... I'll figure out why these are passing at home with different rubies and failing on Travis, better not merge this until CI is fixed.

JustinAiken commented 10 years ago

Yay green! Just needed a little pause to allow the DRB process time to restart; guess Travis's VMs aren't as speedy as a mighty Mac.

Should be clear to merge now.

benlangfeld commented 10 years ago

Did you manage to test this in a real app (perhaps by implementing something in the server object which raises when called)?

JustinAiken commented 10 years ago

Raising exceptions in the server object never breaks the DRB thread that I can find.. but I tried setting up a method in the DRB object that closed the drb connection directly, and whenever calling that, this restarts it successfully in the real app.

benlangfeld commented 10 years ago

Go ahead and merge/release as soon as Travis says yes. You have authorship on the gem.