adhearsion / punchblock

Telephony middleware library for Ruby
adhearsion.com/punchblock
MIT License
40 stars 34 forks source link

Connection options required to be a symbol? #77

Closed jsgoecke closed 12 years ago

jsgoecke commented 12 years ago

Right now it appears when I do a Connect.new it requires that the uname/passwd be passed in as symbols for the key:

/Users/jsgoecke/.rvm/gems/ruby-1.9.2-p180/gems/punchblock-0.4.3/lib/punchblock/connection.rb:27:in initialize': ArgumentError (ArgumentError) from rayo_driver.rb:21:innew' from rayo_driver.rb:21:in `

'

Line 27 is here:

'''ruby raise ArgumentError unless (@username = options[:username]) && options[:password] '''

Seems that maybe it should allow keys to be strings too.

benlangfeld commented 12 years ago

I disagree, and I'm marking this invalid :)