Cloning an SSML document turns it into GRXML

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation

MIT License

101 stars 41 forks source link

Cloning an SSML document turns it into GRXML #26

Closed sfgeorge closed 10 years ago

sfgeorge commented 10 years ago

If you draw a new SSML document and then clone it, the clone has the right XML content but is a RubySpeech::GRXML::Element. As a result, you cannot embed this document into another SSML document. This is shown in the following tests: sfgeorge/ruby_speech@50c5a4a.

It seems that cloning any GenericElements is designed to always produce GRXML document. Cloning an SSML doc should result in another SSML doc.

benlangfeld commented 10 years ago

Could you submit those tests as a pull request? This is most definitely a mistake :)

sfgeorge commented 10 years ago

You bet, added as #27. Thanks!

benlangfeld commented 10 years ago

This was fixed by #28