search

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation
MIT License
101 stars 41 forks source link

Rate bugfix #36

Closed SimonJMurphy closed 8 years ago

SimonJMurphy commented 8 years ago

Adds tests for rate changes that are supplied as a percentage, rather than a decimal multiplier. Facilitates such rate changes.

benlangfeld commented 8 years ago

This is an attempt to close https://github.com/benlangfeld/ruby_speech/issues/31.

@Smurfmeister It's a good idea to do the following:

  1. Add an entry to the changelog (under the develop header, since this is pre-release) explaining the addition here.
  2. Squash to a single commit.
  3. Update the API documentation for this method to reflect a new set of possible values/types.

Additionally, I'm not sure this change is correct. It is possible, according to the spec, to specify a percentage in the resulting document:

<?xml version="1.0"?>
<speak version="1.0" xmlns="http://www.w3.org/2001/10/synthesis"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://www.w3.org/2001/10/synthesis
                   http://www.w3.org/TR/speech-synthesis/synthesis.xsd"
         xml:lang="en-US">
  The price of XYZ is <prosody rate="-10%">$45</prosody>
</speak>

I believe we want to pass these values through, rather than converting them to a decimal representation. The TTS engine would then be responsible for interpreting these values.

Congratulations on your first contribution!

benlangfeld commented 8 years ago

Test failures are unrelated. Merging.