search

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation
MIT License
101 stars 41 forks source link

[FIX] Prevent pre-2.1 rubies from failing when trying to install nokogiri 1.7+ #40

Closed sfgeorge closed 7 years ago

sfgeorge commented 7 years ago

The new Nokogiri 1.7.0 will not install on ruby < 2.1.0

https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md#170--2016-12-26

sfgeorge commented 7 years ago

Ok groovy, sounds good to me. I'm going to attempt to set it back to ~> 1.6.0, but bizzarely I get the "nokogiri-1.7.0 requires ruby version >= 2.1.0, which is incompatible with the current version ..." error when setting nokogiri ~> 1.6.0.

I'll give it one more shot, but I anticipate a Travis build failure. If that fails, let me know if using < 1.7.0 is okay.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.716% when pulling 22c7fc37a479f14882578e08b60125a3bebc9c3c on sfgeorge:feature/nokogiri-lock into 0c4f434e3ff99a764987869630624872cac39822 on benlangfeld:develop.

sfgeorge commented 7 years ago

Oh, I happily stand corrected. I was hitting trouble when using ~> 1.6.x, and ~> 1.6.0 fairs much better in this case.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.716% when pulling 15849a05dd8807ff7516d14fa68cc5a998571b5b on sfgeorge:feature/nokogiri-lock into 0c4f434e3ff99a764987869630624872cac39822 on benlangfeld:develop.

sfgeorge commented 7 years ago

Thank you!