[SPEC] Fix code coverage reporting

sfgeorge commented 7 years ago

Fix code coverage by ensuring that Coveralls.wear! occurs before ruby_speech is loaded.

Note: The Coveralls.wear! must occur before any of your application code is required, so should be at the very top of your spec_helper.rb, test_helper.rb, or env.rb, etc.

https://coveralls.zendesk.com/hc/en-us/articles/201769485-Ruby-Rails

coveralls commented 7 years ago

Coverage decreased (-34.6%) to 64.127% when pulling 896946566bb2af1b9de33f748256206ee42f3084 on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 98.884% when pulling 896946566bb2af1b9de33f748256206ee42f3084 on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 8bae34a11e2e87c33559dde76b58886b33844c7d on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 58cb9df2ef662fa7bfb38113cb62b7477af8aa3a on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 58cb9df2ef662fa7bfb38113cb62b7477af8aa3a on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 58cb9df2ef662fa7bfb38113cb62b7477af8aa3a on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 58cb9df2ef662fa7bfb38113cb62b7477af8aa3a on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 98.384% when pulling 58cb9df2ef662fa7bfb38113cb62b7477af8aa3a on sfgeorge:feature/fix-coveralls into 4586e30531a4d1bb01e4f4eaa21c0e8c945c942f on benlangfeld:develop.

sfgeorge commented 7 years ago

@benlangfeld My bad - I failed to signal to you that I'm still having one minor issue with this branch. I will follow up very shortly with another related PR. Note: Because I took away Coveralls.wear!, we're not posting to coveralls at this moment (Sorry!!)

The Goal: I want to have my cake and eat it too - to have Coveralls for CI + the SimpleCov html formatter for local test runs.

The Problem:

Running SimpleCov.start generates an html report but does not kick off Coveralls
Running Coveralls.wear! with ENV["COVERALLS_RUN_LOCALLY"] = "true" should run both Coveralls and the SimpleCov html formatter, but in practice I don't see coverage/index generated. Digging into why.

adhearsion / ruby_speech

[SPEC] Fix code coverage reporting #41