search

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation
MIT License
101 stars 41 forks source link

Fix CI build for Ruby 2.1 and 2.2 #56

Closed sfgeorge closed 5 years ago

sfgeorge commented 5 years ago

Fix CI build

  1. Main issue: Our manual gem install bundler tries to install Bundler 2.x on all Rubies, including those < 2.3, which is a no-go:

image

Solution is to just simply omit gem install bundler, and just let travis do the work of deciding which version of bundler to install.

  1. drop use of sudo: true/false, as that's deprecated.

  2. Switch to dist: trusty to get slightly closer to successfully running with rbx / Rubinius. Unfortunately, I couldn't get ffi to natively compile under Rubinius and I'm not quite sure why. 😞

  3. Use versions of Ruby 2.3 and 2.4 that come pre-installed on Travis' Xenial build.

  4. Begin testing Ruby 2.5 and 2.6.

sfgeorge commented 5 years ago

@lpradovera @gfaza Can you review this for me sirs?

sfgeorge commented 5 years ago

^ Says the most qualified gentleman on the subject of top hats! 👌

Dig it! 🎉

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 99.199% when pulling 6746f87a9058e8dcbcf14c5a71e325d5bbd257f4 on sfgeorge:fix-ci-for-older-rubies into 3e75302c2e3e5e433f92d33195d8cef7939032db on adhearsion:develop.