[refactor] to generate less garbage (from JRuby ext)

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation

MIT License

101 stars 41 forks source link

[refactor] to generate less garbage (from JRuby ext) #57

Closed kares closed 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 99.199% when pulling fdc455bbd542655c85e10455823d69a6ec6e56d6 on kares:less-garbage into d1f4f25f011cd711e0f1929b8b2318fb81f50f9e on adhearsion:develop.

bklang commented 5 years ago

This looks good to me. @sfgeorge Have you tested this? Thoughts about merging?

sfgeorge commented 5 years ago

@kares Thank you so much for doing this, I agree looks great!

@bklang I'm still yet to test this out. Unfortunately I won't be able to for at least a week, but I'd like to give this a go with some load testing just for funzies.

bklang commented 5 years ago

@sfgeorge Checking in on this - no rush from my end, but I didn't want to lose track of it. Would you let us know if testing goes well so we can consider merging it?

sfgeorge commented 5 years ago

@bklang @kares Sorry guys, I haven't tested this yet. Thank you for the poke. I'll try my best to get to this over the next week. 🎗

sfgeorge commented 5 years ago

@bklang super fast! you must have jedi reflexes!