search

adhearsion / ruby_speech

A ruby library for TTS & ASR document preparation
MIT License
101 stars 41 forks source link

Rails/ActiveSupport 6 allowed #58

Closed szTheory closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage increased (+1.08%) to 99.051% when pulling 2293f2101ef6a7899e54882640fc206ab83b9b27 on szTheory:master into 3e3c75116891f17bc33da7c9ad7684cfeee34ca2 on adhearsion:master.

bklang commented 4 years ago

Thanks for the contribution @szTheory. Have you done any testing with Rails 6? We locked it to < 5.0.0 because that was the latest version we tested with. Can you comment on what testing you've done to ensure compatibility?

szTheory commented 4 years ago

Ran the specs locally with bundle exec rake and they all passed. I'm also running it in an app and CI specs around TTS are still passing.

bklang commented 4 years ago

CI looks ok - failure is due to bundler no longer support Ruby < 2.3.0. I'm going to merge this. Thanks for your contribution!

sfgeorge commented 4 years ago

@szTheory @bklang Head's up, this unfortunately got merged to master instead of the develop branch. We may want to either remove from master, or merge master -> develop.

bklang commented 4 years ago

Thanks for catching that @sfgeorge ! I tried merging master back to develop, but it picks up a bunch of garbage commits that are artifacts of our release process. I've cherry-picked the relevant commit back to develop, which I think will be the least obtrusive change.