search

adhearsion / virginia

A Reel interface to Adhearsion
MIT License
7 stars 10 forks source link

Compatibility with Reel v0.4.0 #2

Closed pungoyal closed 10 years ago

pungoyal commented 10 years ago

Reel has removed Reel::App. This pull request removes the usages from Virginia. Also indicated is the new way to create custom Handlers for Adhearsion now.

lpradovera commented 10 years ago

Good, this is basically what the first version of Virginia used to be. Reel::App will be missed but we can't really do anything about it. Merging.

bklang commented 10 years ago

One comment on this: the change to README isn't exactly a replacement. The old example only served requests to "/dial" while the new example does not.

Also a change of this magnitude probably deserves a big UPGRADING note in the README and a major number version bump, per SemVer.

lpradovera commented 10 years ago

My reasoning was that this was what Virginia was like for a long time anyway, so I figured it was a "revert" of sorts.

pungoyal commented 10 years ago

@polysics yeah, I am not convinced about the reasoning behind dropping Reel::App either.

@bklang agree about the adding a not to CHANGELOG.md. I did not do it because contributing section in README prohibited it.

benlangfeld commented 10 years ago

As for semver, you're pre-1.0, so a minor bump is appropriate. An aside: you have Gemfile.lock checked in, which you most certainly should not.