PIN change confirmation message is played back before the PIN change happens

adhearsion / voicemail

Adhearsion voicemail plugin

MIT License

8 stars 12 forks source link

PIN change confirmation message is played back before the PIN change happens #19

Open CodeMangler opened 10 years ago

CodeMangler commented 10 years ago

MailboxSetPinController plays back the change PIN confirmation message before calling _store.change_pin_formailbox. This is misleading for cases when _change_pin_formailbox fails, since we would have played back a message saying the PIN has been changed, but the PIN hasn't actually been changed.

See: https://github.com/adhearsion/voicemail/blob/develop/lib/voicemail/call_controllers/mailbox_set_pin_controller.rb#L39

benlangfeld commented 9 years ago

Would you be prepared to submit a PR for this, @CodeMangler?