Closed emcgee closed 10 years ago
Looks good to me. @JustinAiken @polysics any thoughts?
Looks good, but would be nice if it could play the "All of your new messages have been successfully deleted" message via either the config prompt or the I18n; otherwise international users won't be able to use this...
@JustinAiken Wouldn't this line pull from I18n if use_i18n
is true?
https://github.com/emcgee/voicemail/blob/6b2dd63dd46dc403ba4abce33cd5b54d4f809958/lib/voicemail/call_controllers/mailbox_cleaner_controller.rb#L30
Oh yes true... been so long since worked on this, that I forgot I made a nice method to magically do that... explicit I18n.t
calls are only needed if there's something different in the prompt (like interpolation or time/date formatting)... But could you add strings to the en.yml template whenever you add them to the ever-growing config hash?
Absolutely. :boom:
Thanks :) :+1: :ship:
Just waiting on Travis
There are a number of places where we are hanging up on a caller if they fail a menu structure. In my mind, this should only happen on the main_menu -- any section_menu (or lower tier) should fall back to the previous higher tier.
Only main_menu should be able to issue the final
hangup.