Configurable I18n provider

adhearsion / voicemail

Adhearsion voicemail plugin

MIT License

8 stars 12 forks source link

Configurable I18n provider #35

Closed CodeMangler closed 10 years ago

CodeMangler commented 10 years ago

Allows assigning a custom I18n provider to be used for resolving I18n keys

(Not sure why all the merge commits are being listed as part of this PR)

benlangfeld commented 10 years ago

The merge commits are here because your branch was based on master. Please rebase on develop.

bklang commented 10 years ago

I'm going to close this in favor of a PR (coming shortly) that will take advantage of adhearsion-i18n.

CodeMangler commented 10 years ago

@bklang would the new PR allow some way to interpolate custom variables in the audio URL? Like "http://%{some_var}.foo.bar/%{another_var}" That was the primary thing we needed this for in GH.

bklang commented 10 years ago

@CodeMangler adhearsion-i18n uses the standard Rails I18n library, which itself does support interpolation (docs). So yes, it should (though I've not personally tested it). If you experience any problems with Adhearsion-i18n, issues are welcome over there.