hotfix/1.1.2

[emcgee]

Quick hotfix to guarantee that the on_end callback is actually used. In the current configuration, Adhearsion can exit without ever seeing the call to setup on_end, thereby leaving voicemails to be delivered to nobody except the recording directory.

[bklang]

Great catch. Need to get the test that is now failing to pass, but otherwise this looks good.

[emcgee]

Spec fixed, but there is another slight problem:

I'm seeing quite a few undefined method "complete_event" errors on this line: https://github.com/adhearsion/voicemail/blob/develop/lib/voicemail/call_controllers/voicemail_controller.rb#L54

Likely because the call is shutting down before the the Record has time, or is instructed, to finish. Up for discussion what is best here - to sleep for a second or two and then process, or poll recording.complete_event for a certain amount of time and then hangup if nonexistent.

[benlangfeld]

@emcgee Please provide evidence of such errors. NoMethodError would not occur because the complete event is not yet set, but rather because @recording is nil. This would happen if hangup occurred while the greeting was being played back, for example. If that callback is going to be set before recording starts, it will need to account for the possibility that recording never starts.

[emcgee]

@benlangfeld Indeed, @recording is nil.

https://gist.github.com/emcgee/2ae85aca3afb68e3e637

Since the callback does need to be set before recording starts, I'll add another line to check for that condition.

[emcgee]

Any more issues with this, or can it be merged?

[bklang]

@emcgee it needs to be rebased to the support/1.x.x branch because develop has moved on to voicemail 2.0. I'm good with it otherwise.

[emcgee]

@bklang Squashed and rebased.