search

adhocore / asserts

More PHPUnit assertions as a Trait
https://github.com/adhocore/asserts
MIT License
9 stars 3 forks source link

About assert string contains #9

Open peter279k opened 5 years ago

peter279k commented 5 years ago

Introduction

It's about the feature request about asserting string contains.

Description

Consider the following points:

Should we implement all these assertions (including deprecated assertions)?

The detailed issues are as follows:

adhocore commented 5 years ago

sorry for late. i think we should not implement deprecated assertions. they are deprecated for some valid reasons. we may however add something new? 😎

peter279k commented 5 years ago

What about Add assertIterableContains() and assertStringContains() in PHPUnit 7.5?

These assertions are new and it's available in PHPUnit 7.5.

peter279k commented 6 months ago

@adhocore, I've removed the comment because it contains the phishing websites.

zhouxing5311 commented 6 months ago

@adhocore, I've removed the comment because it contains the phishing websites.

sorry for that, i accidentally clicked on a phishing link and I have removed the verification for it.

if you recevie an email which told you offer you a job and give you a link to click, it is a phishing link, do not click an delete that email. image